Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move socials to left footer column #211

Merged
merged 7 commits into from
Jul 23, 2024
Merged

Conversation

aheaphy
Copy link
Contributor

@aheaphy aheaphy commented Jul 2, 2024

No description provided.

@aheaphy aheaphy added the testing PR is current being tested label Jul 2, 2024
@fksaintil fksaintil added ready Tested and ready for deployment (unless on-hold) on hold Hold for deployment and removed testing PR is current being tested labels Jul 17, 2024
Copy link
Contributor

@routinet routinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick search for references to that class show it is still referenced in the following files:

web/themes/custom/nysenate_theme/dist/css/all.css
web/themes/custom/nysenate_theme/dist/css/bill-vote-widget.css
web/themes/custom/nysenate_theme/patternlab/css/all.css
web/themes/custom/nysenate_theme/patternlab/css/bill-vote-widget.css
web/themes/custom/nysenate_theme/patternlab/patterns/components-bill-vote-widget-bill-vote-widget/components-bill-vote-widget-bill-vote-widget.twig
web/themes/custom/nysenate_theme/src/patterns/components/bill-vote-widget/bill-vote-widget.scss
web/themes/custom/nysenate_theme/src/patterns/components/bill-vote-widget/bill-vote-widget.twig

@@ -142,7 +149,7 @@ footer {
}

a {
float: left;
//float: left;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented code

@@ -329,7 +341,7 @@ footer {
p {
@include font-stack-secondary;
//display: none;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented code

@routinet
Copy link
Contributor

I found one other reference to the "BETA" tag, but I'm pretty sure it is in a file compiled during deployment (patternlab component twig template web/themes/custom/nysenate_theme/patternlab/patterns/components-bill-vote-widget-bill-vote-widget/components-bill-vote-widget-bill-vote-widget.twig)

@fksaintil fksaintil removed the on hold Hold for deployment label Jul 18, 2024
@kzalewski kzalewski merged commit 58e5945 into main Jul 23, 2024
2 checks passed
@kzalewski kzalewski deleted the feature/nys-16461--footer branch July 23, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Tested and ready for deployment (unless on-hold)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants